Skip to content

MailAddress accepts invalid email address with consecutive dots#109690

Merged
ManickaP merged 2 commits intodotnet:mainfrom
pedrobsaila:109590
Nov 21, 2024
Merged

MailAddress accepts invalid email address with consecutive dots#109690
ManickaP merged 2 commits intodotnet:mainfrom
pedrobsaila:109590

Conversation

@pedrobsaila
Copy link
Contributor

@pedrobsaila pedrobsaila commented Nov 10, 2024

Fixes #109590

@ghost ghost added the area-System.Net label Nov 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 10, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 11, 2024
Closed
ManickaP
ManickaP approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Please also change the comment above the class:

runtime/src/libraries/System.Net.Mail/src/System/Net/Mail/DotAtomReader.cs

Lines 14 to 15 in 35d2780

// or end, but we do allow dots at the end for compatibility with other mail clients. We also allow
// multiple consecutive dots, which would normally be invalid.

And we need to change the docs as well as they explicitly mention allowing double dots:
https://learn.microsoft.com/dotnet/api/system.net.mail.mailaddress#remarks

@build-analysis build-analysis bot mentioned this pull request Nov 11, 2024
Closed
3 tasks
@ManickaP ManickaP merged commit 0d55c5b into dotnet:main Nov 21, 2024
@pedrobsaila pedrobsaila deleted the 109590 branch November 22, 2024 08:31
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@pedrobsaila @mikelle-rogers
MailAddress accepts invalid email address with consecutive dots (dotn…
5fc0490 
…et#109690)

* MailAddress accepts invalid email address with consecutive dots

* update DotAtomReader class comment
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2024
@gewarren
Copy link
Contributor

gewarren commented Jan 1, 2026

@ericstj Does this need to be documented as a breaking change? See dotnet/docs#50592.

@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Jan 9, 2026
@ericstj
Copy link
Member

ericstj commented Jan 9, 2026

Yeah it should be. Today, reviewers self-identify, maybe we can get copilot to help in the future

@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jan 9, 2026
@dotnet dotnet unlocked this conversation Jan 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

📋 Breaking Change Documentation Required

Create a breaking change issue with AI-generated content

Generated by Breaking Change Documentation Tool - 2026-01-10 00:23:17

@ericstj
Copy link
Member

ericstj commented Jan 10, 2026

@ManickaP -- did you want to create the doc using the link above?

@ManickaP
Copy link
Member

ManickaP commented Jan 12, 2026

Is this a braking change? I would not consider it as such. It's just making the implementation follow RFC more closely. But correct me if I'm wrong.

@rzikm
Copy link
Member

rzikm commented Jan 12, 2026

Is this a braking change? I would not consider it as such.

The new code behaves differently from previously documented behavior (is more restrictive). I think that counts as a breaking change (regardless how bad the previous behavior was)

@ManickaP ManickaP mentioned this pull request Jan 12, 2026
Closed
Copilot AI mentioned this pull request Jan 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ManickaP ManickaP ManickaP approved these changes

Assignees

No one assigned

Labels

area-System.Net breaking-change Issue or PR that represents a breaking API or functional change over a previous release. community-contribution Indicates that the PR has been added by a community member needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MailAddress accepts invalid email address with consecutive dots

5 participants

@pedrobsaila @gewarren @ericstj @ManickaP @rzikm